RFR: 8185062: Set AssumeMP to true and deprecate the flag

David Holmes david.holmes at oracle.com
Thu Sep 28 06:19:19 UTC 2017


Hi Aleksey,

On 28/09/2017 4:11 PM, Aleksey Shipilev wrote:
> On 09/28/2017 08:01 AM, David Holmes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8185062
>> Webrev: http://cr.openjdk.java.net/~dholmes/8185062/webrev/
> 
> Looks good.

Thanks for taking a look so quickly! :)

> *) This change is micro-optimization, right? Double-space before AssumeMP:
> 
>   216     return  AssumeMP || (_processor_count != 1);

:) Congratulations you passed the reviewer test. Fixed.

>> CSR request: https://bugs.openjdk.java.net/browse/JDK-8188079
>>
>> Can I please get a reviewer for the CSR request (edit it and add your OpenJDK user name to the
>> "Reviewed by" box).
> 
> Who is allowed to do this?

https://wiki.openjdk.java.net/display/csr/CSR+FAQs

Q: Who should be a reviewer on a CSR proposal?
A: One or more engineers with expertise in the areas impacted by the 
proposed change should review the CSR request and be listed as a 
reviewer before the proposal is reviewed by the CSR membership. (These 
engineers may or may not be Reviewers on the corresponding JDK project.) 
It is appropriate to ask a CSR member to review a request in a area 
where he or she has expertise, but it is not necessary for a CSR member 
to review a request before the CSR body considers it. To encourage wider 
reviews, it is preferable if the CSR chair is not the only reviewer of a 
CSR request. The CSR may request a proposal be reviewed by additional 
engineers before further considering the request.
---

And of course you must have an OpenJDK username.

Thanks,
David
-----

> -Aleksey
> 


More information about the hotspot-dev mailing list