RFR (M) 8198313: Wrap holder object for ClassLoaderData in a WeakHandle
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Mon Apr 2 19:22:32 UTC 2018
On 3/31/18 2:40 PM, Kim Barrett wrote:
>> On Mar 30, 2018, at 1:53 PM, coleen.phillimore at oracle.com wrote:
>>
>>
>> I have an incremental and full .02 version with the changes discussed here.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8198313.02.incr/webrev
>> open webrev at http://cr.openjdk.java.net/~coleenp/8198313.02/webrev
>>
>> These have been retested on x86, all hotspot jtreg tests.
>> thanks,
>> Coleen
> Looks good.
>
> In InstanceKlass::klass_holder_phantom, the klass_ prefix seems
> unnecessary. I don't need a new webrev if you decide to change the
> name.
Since it's pre-existing, I don't think I'll address it with this change.
Thank you for the review.
Coleen
More information about the hotspot-dev
mailing list