RFR (XS) 8200608: Build failures after JDK-8191101 (Show register content in hs-err file on assert)

Aleksey Shipilev shade at redhat.com
Tue Apr 3 09:18:03 UTC 2018


Bug:
 https://bugs.openjdk.java.net/browse/JDK-8200608

"jlong" is not "intx" in x86_32. The fix is simple, because os::current_thread_id() actually returns
intx. I think the fix falls under triviality rule.

--- a/src/hotspot/share/utilities/debug.cpp     Tue Apr 03 10:27:46 2018 +0200
+++ b/src/hotspot/share/utilities/debug.cpp     Tue Apr 03 11:04:01 2018 +0200
@@ -731,7 +731,7 @@
     os::protect_memory((char*)g_assert_poison, os::vm_page_size(), os::MEM_PROT_RWX);
     // Store Context away.
     if (ucVoid) {
-      const jlong my_tid = os::current_thread_id();
+      const intx my_tid = os::current_thread_id();
       if (Atomic::cmpxchg(my_tid, &g_asserting_thread, (intx)0) == 0) {
         if (store_context(ucVoid)) {
           g_assertion_context = &g_stored_assertion_context;


Testing: x86_32 and x86_64 builds

Thanks,
-Aleksey



More information about the hotspot-dev mailing list