RFR (XL) 8081519 Split globals.hpp to factor out the Flag class

[Gerard Ziemski]

Thank you Magnus for the catch!


cheers

> On Apr 3, 2018, at 5:20 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
> 
> 
> 
> On 2018-04-03 12:13, Magnus Ihse Bursie wrote:
>> On 2018-03-29 21:01, Gerard Ziemski wrote:
>>> Hi all,
>>> 
>>> Please review this large and tedious (sorry), but simple fix that accomplishes the following:
>>> 
>>> #1 factor out the command option flag related APIs out of globals.hpp/.cpp into its own dedicated files, i.e. jvmFlag.hpp/.cpp
>>> #2 merge Flag (too generic name) and CommandLineFlag classes and rename them as JVMFlag
>>> #3 cleanup globals.hpp includes originally added by the JEP-245
>>> 
>>> Note: the renamed file retain their history, but one needs to add “follow” flag, ex. “hg log -f file”
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8081519
>>> http://cr.openjdk.java.net/~gziemski/8081519_rev1
>> 
>> Hi Gerard,
>> 
>> More or less by chance I looked at a random file in your review. 
> 
> ... and the "random" file, perhaps I should tell you, is the new jvmFlag.cpp. (Also seems to be fore jvmFlag.hpp.)
> 
> /Magnus
> 
>> I noticed that the copyright line does not follow the Oracle standard:
>> 2  * Copyright (c) 2018 Oracle and/or its affiliates. All rights reserved.
>> 
>> should be:
>> 2  * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
>> 
>> /Your friendly typo detector. :)
>> 
>>> 
>>> Passes Mach5 hs_tier1-tier5, jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges tests.
>>> 
>>> 
>>> cheers
>> 
>