RFR: 8200630: Globally suppress Visual Studio warning C4351

Kim Barrett kim.barrett at oracle.com
Tue Apr 3 23:22:17 UTC 2018


> On Apr 3, 2018, at 5:53 PM, George Triantafillou <george.triantafillou at oracle.com> wrote:
> 
> Hi Kim,
> 
> This looks good.

Thanks.

> -George
> 
> On 4/3/2018 5:00 PM, Kim Barrett wrote:
>> Please review this change to globally suppress Visual Studio warning
>> C4351.  This warning is entirely useless to us.  All it does is
>> interfere with writing clear and correct code.  (See bug for more
>> details.)
>> 
>> This change also removes the one existing occurrence of local
>> suppression of this warning, which is no longer needed.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8200630
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8200630/open.00/
>> 
>> Testing:
>> Build on all Oracle supported platforms, and ran hs-tier1.




More information about the hotspot-dev mailing list