RFR (XS): 8201167: Remove MacroAssembler::cmp_heap_oop on x86

Erik Österlund erik.osterlund at oracle.com
Thu Apr 5 08:24:52 UTC 2018


Hi Aleksey,

Thanks for the review.

/Erik

On 2018-04-05 10:20, Aleksey Shipilev wrote:
> On 04/05/2018 10:09 AM, Erik Österlund wrote:
>> The MacroAssembler::cmp_heap_oop member function on x86 is not currently used anywhere in hotspot.
>> Moreover, it is no longer safe to use it with modern GCs using load barriers. Since it is unsafe to
>> use and is not used today, it should be removed.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8201167/webrev.00/
> Yes, there is MacroAssembler::cmpoop for that.
>
> Looks good!
>
> -Aleksey



More information about the hotspot-dev mailing list