RFR: 8201136: Move GC flags from globals.hpp to GC specific files

Stefan Karlsson stefan.karlsson at oracle.com
Thu Apr 5 09:46:37 UTC 2018


On 2018-04-05 11:42, Stefan Johansson wrote:
> 
> 
> On 2018-04-05 08:11, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this patch to move GC flags out of globals.hpp and into 
>> GC specific files.
>>
>>   http://cr.openjdk.java.net/~stefank/8201136/webrev.01
>>   https://bugs.openjdk.java.net/browse/JDK-8201136
>>
> Really nice! It would be even nicer with a few newlines in the VM_FLAGS 
> and GC_FLAGS macros, I think it would improve readability.
> 
> I also used PrintFlagsFinal and checked that no flags were lost in the 
> move.

Thanks StefanJ!

Here are new webrevs with a cleanup patch proposed by StefanJ. Look at 
the patch to see the correct indentation.

http://cr.openjdk.java.net/~stefank/8201136/webrev.02.delta
http://cr.openjdk.java.net/~stefank/8201136/webrev.02

Thanks,
StefanK

> 
> Thanks,
> Stefan
> 
>> This is one step towards:
>>   https://bugs.openjdk.java.net/browse/JDK-8200729 - Conditional 
>> compilation of GCs
>>
>> With this patch we only have to update gc_globals.hpp when adding new 
>> GCs.
>>
>> Thanks,
>> StefanK


More information about the hotspot-dev mailing list