RFR: 8201136: Move GC flags from globals.hpp to GC specific files

[Stefan Karlsson]

Thanks, Robbin.

StefanK

On 2018-04-05 11:26, Robbin Ehn wrote:
> On 2018-04-05 11:04, Aleksey Shipilev wrote:
>> On 04/05/2018 08:11 AM, Stefan Karlsson wrote:
>>> Please review this patch to move GC flags out of globals.hpp and into 
>>> GC specific files.
>>>
>>>   http://cr.openjdk.java.net/~stefank/8201136/webrev.01
>>>   https://bugs.openjdk.java.net/browse/JDK-8201136
>>
>> Oooof, what a move! I like it, looks good.
> 
> +1
> 
> /Robbin
> 
>>
>> *) In globals.hpp, L2987-..., you probably want to right-adjust the 
>> backslashes?
>>
>> *) In gc_globals.hpp, we still have Use{CMS,Serial,G1,Parallel,...}GC 
>> -- is the intent to have these
>> in shared gc_globals.hpp, not in per-GC-globals.hpp, and check for GC 
>> support at init? In other
>> words, when conditional GC compilation arrives, we still have GC 
>> enabling flags available, but not
>> the GC-specific flags?
>>
>> Thanks,
>> -Aleksey
>>