Hotspot segfaulting on Linux SPARC

[David Holmes]

On 9/04/2018 9:23 PM, John Paul Adrian Glaubitz wrote:
> On 04/09/2018 01:10 PM, David Holmes wrote:
>>> Here's the output of the java command with the change os::free > ::free:
>>
>> You didn't apply Zhengyu's patch as well did you?
> I did apply his patch as well. So, the total changes are:

My suggesting was to change os::free to ::free to match the ::strdup 
_instead_ of Zhengyu's suggestion to change the ::strdup to os::strdup.

David
-----

> diff -r cd4da74e310b src/hotspot/cpu/sparc/assembler_sparc.cpp
> --- a/src/hotspot/cpu/sparc/assembler_sparc.cpp Fri Apr 06 19:16:33 2018 
> +0200
> +++ b/src/hotspot/cpu/sparc/assembler_sparc.cpp Mon Apr 09 11:23:38 2018 
> +0000
> @@ -49,7 +49,7 @@
>       uint32_t insn = *reinterpret_cast<uint32_t*>(pc);
> 
>       // 1. General case: No CTI immediately after other CTI
> -    assert(!(is_cti(prev) && is_cti(insn)), "CTI-CTI not allowed.");
> +    // assert(!(is_cti(prev) && is_cti(insn)), "CTI-CTI not allowed.");
> 
>       // 2. Special case: No CTI immediately after/before RDPC
>       assert(!(is_cti(prev) && is_rdpc(insn)), "CTI-RDPC not allowed.");
> diff -r cd4da74e310b 
> src/hotspot/os_cpu/linux_sparc/vm_version_linux_sparc.cpp
> --- a/src/hotspot/os_cpu/linux_sparc/vm_version_linux_sparc.cpp Fri Apr 
> 06 19:16:33 2018 +0200
> +++ b/src/hotspot/os_cpu/linux_sparc/vm_version_linux_sparc.cpp Mon Apr 
> 09 11:23:38 2018 +0000
> @@ -48,7 +48,7 @@
>           if (vstr != NULL) {
>             // We have a matching line and a valid starting point to the 
> value of
>             // the field, copy the string for keeps.
> -          _string = strdup(vstr);
> +          _string = os::strdup(vstr, mtInternal);
>             break;
>           }
>         }
>