RFR: 8201168: Move GC command line constraint functions to GC specific files

Gerard Ziemski gerard.ziemski at oracle.com
Mon Apr 9 16:53:31 UTC 2018


hi Stefan,

Nice cleanup, looks good.

Shouldn’t the new files have just “2018," as the copyright year, not "2015, 2018,"?

Also, what tests did you run?

ps. Don’t worry about my changes, I will wait for yours to go in, then I’ll merge.


cheers

> On Apr 5, 2018, at 5:03 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> 
> Hi all,
> 
> Please review this patch to move the GC flag constraint functions into GC specific files.
> 
> http://cr.openjdk.java.net/~stefank/8201168/webrev.01
> https://bugs.openjdk.java.net/browse/JDK-8201168
> 
> This is one step towards:
> 
> https://bugs.openjdk.java.net/browse/JDK-8200729 - Conditional compilation of GCs
> 
> I know that this conflicts with Gerards rename of the flags to JVMFlags, but I don't want to wait for that to get pushed before publishing this review request.
> 
> Thanks,
> StefanK



More information about the hotspot-dev mailing list