RFR: 8200550: Xcode 9.3 produce warning on heapRegionSet.hpp

Kim Barrett kim.barrett at oracle.com
Mon Apr 9 20:48:40 UTC 2018


> On Apr 9, 2018, at 3:05 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> I agree that we may probably just remove optimized builds for the above
> stated reasons, but that is another discussion :)

Perhaps, and yes, that’s another discussion.

>>> So yes, I recommend removing this capability in this instance. This
>>> verification does not seem to be any different than any other.
>>> 
>>> Not sure if this capability is too expensive or not (this is
>>> typically a bit fuzzy), but in the worst case one can use
>>> NOT_DEBUG_RETURN.
>> 
>> Since it was previously only under ASSERT, I'm leaving it that way.
>> 
>> New webrevs:
>> full: http://cr.openjdk.java.net/~kbarrett/8200550/open.01/
>> incr: http://cr.openjdk.java.net/~kbarrett/8200550/open.01.inc/
> 
>  looks good.

Thanks.

> Thanks,
>  Thomas




More information about the hotspot-dev mailing list