RFR (S) 8201370: Minimal VM build fail

[Stefan Karlsson]

On 2018-04-10 23:58, David Holmes wrote:
> Hi Stefan,
> 
> On 11/04/2018 5:45 AM, Stefan Karlsson wrote:
>> Hi Boris,
>>
>> Thanks for fixing this!
>>
>> For some reason I didn't bring those changes over from my original 
>> patch to prototype conditional compilation of the GCs:
>> http://cr.openjdk.java.net/~stefank/8200729/prototype/webrev.01/
>>
>> I've rebased that patch on my latest pushed changes and this should be 
>> a much smaller patch:
>> http://cr.openjdk.java.net/~stefank/8200729/prototype/webrev.02/
>>
>> I'll go through that patch and see if there is something else I've 
>> missed.
>>
>> Regarding your patch, I think that you could push this and get rid of 
>> the Minimal VM build breakage, but please also consider the comments 
>> below:
>>
>> I see that you've added some includes to precompiled.hpp. This might be 
> 
> They weren't added, they were moved from being unconditional into the 
> INCLUDE_ALL_GCS section.

You're right. I missed those red lines when I looked at this last night. 
So, nothing to see here, please move along. ;)

Thanks,
StefanK

> 
> David
> -----
> 
>> fine if you want to solve the urgent build problem, but ultimately we 
>> should be able to compile minimalvm with '--build-configure-args 
>> --disable-precompiled-headers'. Adding headers to the precompiled.hpp 
>> file should never be done to solve include dependency problem. If 
>> there are missing includes those needs to be added to the files that 
>> uses the code in the missing header files.
>>
>> Thanks,
>> StefanK
>>
>> On 2018-04-10 18:56, Boris Ulasevich wrote:
>>> Hi all,
>>>
>>> Please review this patch to fix Minimal VM build fail caused by 
>>> recent GC headers updating.
>>>
>>>  https://bugs.openjdk.java.net/browse/JDK-8201370
>>>  http://cr.openjdk.java.net/~dchuyko/boris.ulasevich/8201370/webrev.00/
>>>
>>> I will post separate review on arm32-specific changes.
>>>
>>> Thanks,
>>> Boris
>>
>>