RFR(xxs, trivial): 8201475: 8199417 breaks AIX and non-pch on s390 (and presumably aarch64)

Thomas Stüfe thomas.stuefe at gmail.com
Thu Apr 12 08:56:46 UTC 2018


rebased and with Alexeys addition:

http://cr.openjdk.java.net/~stuefe/webrevs/8201475-buildfix/webrev.01/webrev/

still good? I like to push this before I need to rebase again...

On Thu, Apr 12, 2018 at 10:39 AM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> Will do that.
>
> On Thu, Apr 12, 2018, 10:23 Doerr, Martin <martin.doerr at sap.com> wrote:
>>
>> Hi Thomas,
>>
>> thanks for fixing. Looks good. I think it should get pushed today before
>> jdk/hs gets closed.
>>
>> Best regards,
>> Martin
>>
>>
>> -----Original Message-----
>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf
>> Of Thomas Stüfe
>> Sent: Donnerstag, 12. April 2018 07:37
>> To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
>> Subject: RFR(xxs, trivial): 8201475: 8199417 breaks AIX and non-pch on
>> s390 (and presumably aarch64)
>>
>> Hi all,
>>
>> may I have reviews for this small trivial build fix.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8201475
>>
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8201475-buildfix/webrev.00/webrev/
>>
>> sharedRuntime.hpp was missing from the cpu specific files.
>>
>> aarch64 looked broken too so I fixed it blindly, the fix seemed simple
>> enough. Could aarch64 folks eye this over please?
>>
>> Thank you, Thomas


More information about the hotspot-dev mailing list