RFR: 8201597: AArch64: Update relocs for CompiledDirectStaticCall

Andrew Dinn adinn at redhat.com
Mon Apr 16 16:03:30 UTC 2018


On 16/04/18 16:26, Andrew Haley wrote:
> http://cr.openjdk.java.net/~aph/8201597/
> 
> We're not updating the relocs for OOPs and metadata in compiled static
> stubs.  Fixed thusly:
> 
>   http://cr.openjdk.java.net/~aph/8201597/

Code changes look good.

Your webrev doesn't seem to have found a IRA issue yet though.

Also, you appear to have updated the Red Hat copyright but not the
Oracle one. Is that kosher?

> Every other target except x86 does the same thing, with similar code.
> I'm therefore baffled that this isn't done in shared code; it
> certainly could be.
Hmm, yes. All of them with minor differences in irrelevant details just
to keep you on your toes. What larks, eh!

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the hotspot-dev mailing list