8185505: AArch64: Port AOT

Ningsheng Jian Ningsheng.Jian at arm.com
Mon Apr 16 08:53:01 UTC 2018


Hi Andrew,

This is great! Some minor comments:

I can see both the jdk patch and Graal PR contain changes of AArch64Assembler.java and AArch64MacroAssembler.java, but the changes looks somewhat different. How will they be synced?

I noticed that in make/hotspot/lib/JvmFeatures.gmk line ~144, there's:

  JVM_EXCLUDE_FILES += \
      compiledIC_aot_x86_64.cpp

Do you want to add compiledIC_aot_aarch64.cpp to that list?

I also found that _immutable_PIC and its getters/setters are in the INCLUDE_AOT block, but some of their uses are not:

src/hotspot/cpu/aarch64/compiledIC_aarch64.cpp:

61   if (cbuf.immutable_PIC()) {

src/hotspot/share/jvmci/jvmciCodeInstaller.cpp:

594   buffer.set_immutable_PIC(_immutable_pic_compilation);
628   buffer.set_immutable_PIC(_immutable_pic_compilation);

Thanks,
Ningsheng

> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Andrew Haley
> Sent: Saturday, April 14, 2018 1:01 AM
> To: hotspot-dev at openjdk.java.net
> Subject: RFR: 8185505: AArch64: Port AOT
> 
> http://cr.openjdk.java.net/~aph/8185505-1
> 
> The corresponding Graal changes are at
> 
> https://github.com/oracle/graal/pull/334/files
> 
> I think I've done all the things that reviewers mentioned.  There is a clean set
> of test result for JVMCI and AOT.  Thank you everyone.
> 
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the hotspot-dev mailing list