8185505: AArch64: Port AOT

[Vladimir Kozlov]

And I forgot to say that changes looks good to me.

Thanks,
Vladimir

On 4/17/18 9:53 AM, Vladimir Kozlov wrote:
> On 4/16/18 2:03 AM, Andrew Haley wrote:
>> On 04/16/2018 09:53 AM, Ningsheng Jian wrote:
>>> I can see both the jdk patch and Graal PR contain changes of AArch64Assembler.java and 
>>> AArch64MacroAssembler.java, but the changes looks somewhat different. How will they be synced?
>>
>> The changes to Graal in JDK do no more than allow OpenJDK to build.  They
>> are not called by anything, and will disappear at the next Graal import.
>>
>>> I noticed that in make/hotspot/lib/JvmFeatures.gmk line ~144, there's:
>>>
>>>    JVM_EXCLUDE_FILES += \
>>>        compiledIC_aot_x86_64.cpp
>>>
>>> Do you want to add compiledIC_aot_aarch64.cpp to that list?
>>
>> I don't really know what this does, so I have no idea.
> 
> It was done when we did not support/build AOT on Win and MacOS. It also work when AOT is disabled in 
> build: configure --disable-aot
> We have to exclude to AOT files to avoid build failure because they do not have #ifdef INCLUDE_AOT.
> 
> I think compiledIC_aot_aarch64.cpp should be added to exclude list too. And you can test you code 
> with --disable-aot
> 
> Vladimir
> 
>>
>>> I also found that _immutable_PIC and its getters/setters are in the INCLUDE_AOT block, but some 
>>> of their uses are not:
>>>
>>> src/hotspot/cpu/aarch64/compiledIC_aarch64.cpp:
>>>
>>> 61   if (cbuf.immutable_PIC()) {
>>>
>>> src/hotspot/share/jvmci/jvmciCodeInstaller.cpp:
>>>
>>> 594   buffer.set_immutable_PIC(_immutable_pic_compilation);
>>> 628   buffer.set_immutable_PIC(_immutable_pic_compilation);
>>
>> Thank you.  For the sake of consistency I will change it.
>>