[11]RFR(S): 8201509: Zero : S390x (S390 and not _LP64) atomic_copy64 inline assembler is wrong.
Aleksey Shipilev
shade at redhat.com
Wed Apr 18 09:20:00 UTC 2018
On 04/17/2018 05:46 PM, Chris Phillips wrote:
> Hi,
>
> Please review this small but significant change to Zero only code
> related to S390 (31bit) Zero self-build failures.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8201509
> webrev: http://cr.openjdk.java.net/~chrisphi/JDK-8201509/webrev.1
Looks okay to me.
In addition to discussion in the bug itself, it seems we can argue it should look similar to the
PPC32 && !__SPE__ block above. Which is does, as far as operands are concerned. But, are we sure
ld/std is enough to copy 64 bits on S390? I assume "d" is for double in those insns?
Thanks,
-Aleksey
More information about the hotspot-dev
mailing list