RFR: 8202082: Remove explicit CMS checks in CardTableBarrierSetAssembler

Erik Österlund erik.osterlund at oracle.com
Mon Apr 23 11:26:56 UTC 2018


Hi Thomas,

Thanks for the review.

/Erik

On 2018-04-23 13:12, Thomas Schatzl wrote:
> Hi,
>
> On Fri, 2018-04-20 at 16:43 +0200, Erik Österlund wrote:
>> Hi,
>>
>> In CardTableBarrierSetAssembler, we sometimes need fencing due to
>> the
>> card table being scanned concurrently when using CMS with pre-
>> cleaning.
>> Rather than explicitly checking for those CMS flags in the generic
>> CardTableBarrierSetAssembler class, it is preferrable to check the
>> CardTable scanned_concurrently() property which already precisely
>> reflects that.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8202082
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8202082/webrev.00/
>    looks good.
>
> Thomas



More information about the hotspot-dev mailing list