8185505: AArch64: Port AOT
Andrew Haley
aph at redhat.com
Tue Apr 24 13:26:54 UTC 2018
On 04/24/2018 06:45 AM, Ningsheng Jian wrote:
> Specifically for the link error Yang met, since the stub code (not
> the GOT cases) and the call site are both in .text section, I think
> it might be helpful to issue warning/error when generating the
> relocation entry (before the long time linking phase).
We don't know that the overflow will happen until ink time.
> Two more nits:
>
> My Eclipse has some warnings that there are some imports never used in these files:
> - AArch64JELFRelocObject.java
> - AMD64JELFRelocObject.java
> Maybe remove those unused imports in these two files?
>
> In file AArch64JELFRelocObject.java, line 110:
> case Elf64_Ehdr.EM_AARCH64:
> // Return R_X86_64_* entries based on relocType
> Should the comment be R_AARCH64_* ?
Yes, thanks.
--
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the hotspot-dev
mailing list