RFR (XXS) 8202164: Remove some unneeded BoolObjectClosure* is_alive parameters

[coleen.phillimore at oracle.com]

On 4/23/18 9:28 PM, Kim Barrett wrote:
>> On Apr 23, 2018, at 7:12 PM, coleen.phillimore at oracle.com wrote:
>>
>> See bug for details.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8202164.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8202164
>>
>> Tested with runThese (lots of class unloading) for all the GCs and with mach5 hs-tier1 and 2.
>> Thanks,
>> Coleen
> I don’t think I’d call this XXS.
>
> Looks good.
>
> Needs a couple comment updates; I don't need a new webrev for these.
>
> ------------------------------------------------------------------------------
> src/hotspot/share/code/nmethod.cpp
> 1039   flush_dependencies(/*delete_immediately*/false);
>
> The preceding comment needs to be updated; there's no longer a closure
> involved.

I thought I'd gotten them all.   I changed the comment to this. There's 
a more thorough comment in flush_dependencies that explains why.

   // If this work is being done during a GC, defer deleting 
dependencies from the
   // InstanceKlass.
>
> ------------------------------------------------------------------------------
> src/hotspot/share/code/nmethod.cpp
> 1364         // During GC delete_immediately is false, and is used to
> 1365         // determine liveness of dependees that need to be updated.
> 1366         if (delete_immediately || klass->is_loader_alive()) {
>
> The comment needs to be updated; delete_immediately doesn't determine
> liveness.

Some rewording hopefully makes more sense:

         // During GC delete_immediately is false, and liveness
         // of dependee determines class that needs to be updated.
         if (delete_immediately || klass->is_loader_alive()) {


Thanks,
Coleen
> ------------------------------------------------------------------------------
>