RFR (XS) 8202367: AIX build broken after JDK-8201543 (Modularize C1 GC barriers)

Erik Österlund erik.osterlund at oracle.com
Fri Apr 27 09:57:26 UTC 2018


Hi,

Looks good.

Thanks,
/Erik

On 2018-04-27 11:53, Langer, Christoph wrote:
>
> Hi,
>
> please review a small fix for the AIX build that’s broken after 
> JDK-8201543 was pushed. We needs the include gc/shared/cardTable.hpp 
> in gc/shared/c1/cardTableBarrierSetC1.cpp, otherwise the compiler 
> complains about the usage of CardTable like this:
>
> "/usr/work/d062122/OpenJDK/jdk/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp", 
> line 70.34: 1540-0062 (S) The incomplete class "CardTable" must not be 
> used as a qualifier.
>
> This is the proposed patch:
>
> diff -r 25e6d8bb5a6e 
> src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp
>
> --- a/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp Fri Apr 
> 27 11:00:57 2018 +0200
>
> +++ b/src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp Fri Apr 
> 27 11:44:16 2018 +0200
>
> @@ -24,6 +24,7 @@
>
> #include "precompiled.hpp"
>
> #include "gc/shared/c1/cardTableBarrierSetC1.hpp"
>
> +#include "gc/shared/cardTable.hpp"
>
> #include "gc/shared/cardTableBarrierSet.hpp"
>
> #include "utilities/macros.hpp"
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202367 
> <https://bugs.openjdk.java.net/browse/JDK-8202367>
>
> Thanks
>
> Christoph
>



More information about the hotspot-dev mailing list