URGENT RFR(XS): 8202386 [BACKOUT] fix for 8200235

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Apr 27 19:39:39 UTC 2018


Thanks Jerry!

Dan


On 4/27/18 3:38 PM, Gerald Thornbrugh wrote:
> Hi Dan,
>
> Looks like a good backout, thumbs up!
>
> Jerry
>> On Apr 27, 2018, at 1:25 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
>>
>> Greetings,
>>
>> Recent testing has revealed an issue with the following fix:
>>
>>      JDK-8200235 Generalize jniFastGetField jobject/jweak resolve
>>      https://bugs.openjdk.java.net/browse/JDK-8200235
>>
>> The following bug is tracking the new failure mode:
>>
>>      JDK-8202381 (Solaris) SIGBUS in # V [libjvm.so+0xcee494] jni_GetIntField+0x224
>>      https://bugs.openjdk.java.net/browse/JDK-8202381
>>
>> The following bug is being used to backout the fix for JDK-8200235:
>>
>>      JDK-8202386 [BACKOUT] fix for 8200235
>>      https://bugs.openjdk.java.net/browse/JDK-8202386
>>
>>
>> Here's the backout webrev:
>>
>> http://cr.openjdk.java.net/~dcubed/8202386-webrev/0_for_jdk_jdk/
>>
>> The backout was generated by:
>>
>>      $ hg log -v -r 4745598b307f
>>      changeset:   49898:4745598b307f
>>      user:        eosterlund
>>      date:        Thu Apr 26 11:56:24 2018 +0200
>>      files: src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.hpp src/hotspot/cpu/aarch64/jniFastGetField_aarch64.cpp src/hotspot/cpu/sparc/gc/shared/barrierSetAssembler_sparc.cpp src/hotspot/cpu/sparc/gc/shared/barrierSetAssembler_sparc.hpp src/hotspot/cpu/sparc/jniFastGetField_sparc.cpp src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp src/hotspot/cpu/x86/jniFastGetField_x86_64.cpp
>>      description:
>>      8200235: Generalize jniFastGetField jobject/jweak resolve
>>      Reviewed-by: kbarrett, dholmes
>>
>>      $ hg backout 4745598b307f
>>      9 files updated, 0 files merged, 0 files removed, 0 files unresolved
>>      changeset 4745598b307f backed out, don't forget to commit.
>>
>>      $ hg commit
>>
>>      $ hg log -v -r tip
>>      changeset:   49917:a1765a10c340
>>      tag:         tip
>>      user:        dcubed
>>      date:        Fri Apr 27 14:56:20 2018 -0400
>>      files: src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.hpp src/hotspot/cpu/aarch64/jniFastGetField_aarch64.cpp src/hotspot/cpu/sparc/gc/shared/barrierSetAssembler_sparc.cpp src/hotspot/cpu/sparc/gc/shared/barrierSetAssembler_sparc.hpp src/hotspot/cpu/sparc/jniFastGetField_sparc.cpp src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp src/hotspot/cpu/x86/jniFastGetField_x86_64.cpp
>>      description:
>>      Merge
>>
>> I sanity checked the backout with:
>>
>>
>> $ hg diff -r 49897 `cat file.list` | wc
>>         0       0       0
>>
>> which compares the changeset before 49898:4745598b307f
>> with the current tip. All is good.
>>
>> Dan
>>



More information about the hotspot-dev mailing list