RFR(L) : 8199643 : [TESTBUG] Open source common VM testbase code

[Vladimir Ivanov]

Looks good.

Best regards,
Vladimir Ivanov

On 4/27/18 15:06, Igor Ignatyev wrote:
> pasted a wrong link, here is the right one --  http://cr.openjdk.java.net/~iignatyev/8199643/webrev.00/index.html <http://cr.openjdk.java.net/~iignatyev/8199643/webrev.00/index.html>
> 
> -- Igor
> 
>> On Apr 27, 2018, at 2:50 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
>>> 58155 lines changed: 58155 ins; 0 del; 0 mod;
>>
>> Hi all,
>>
>> could you please review this webrev which open sources code shared by many tests from so-called VM testbase?
>>
>> this patch doesn't include any tests, it's rather a preparation step to simplify actual open sourcing of the tests, which will be done later by separate RFEs[*]. the files are intentionally put into a separate directory (test/hotspot/jtreg/vmTestbase) to emphasize that these tests were a part of one "product", most of the code doesn't meet openjdk coding guidelines (or any other coding guidelines for that matter), might be highly coupled and duplicate some existing test and/or test libraries from jtreg test bases. in a long term, we are planning to rework all these tests and make them more like other regular jtreg tests.
>>
>> I'd like to highlight that the code in this webrev isn't new, VM testbase tests have been using it for a long time and these tests have been by Oracle for internal hotspot testing for a long period if time. however as this patch adds "new" native code, I'd really like platforms' maintainers to closely review all .h/.c files (esp. libProcessUtils.c and all the files used by it) as they were never built/executed on platforms other than the ones supported by Oracle.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8199643
>> webrev: http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html
>> testing:
>> - all tests which depend on this code
>> - build linux-x64, windows-x64, mac-x64, solaris-sparcv9 including open-only variants
>>
>> [*] JBS:(labels = test-opensource and component = hotspot)
>> https://bugs.openjdk.java.net/issues/?jql=labels%20%3D%20test-opensource%20and%20component%20%3D%20hotspot
>>
>> Thanks,
>> -- Igor
>