[8u] RFR: 8196882: VS2017 Hotspot Defined vsnprintf Function Causes C2084 Already Defined Compilation Error

[Kevin Walls]

Great, thanks Kim!

Yes, the g1GCPhaseTimes.cpp code went away in jdk9 with 8150068 (Log the 
main G1 phases at info level).

Thanks
Kevin


On 01/08/2018 21:17, Kim Barrett wrote:
>> On Aug 1, 2018, at 10:47 AM, Kevin Walls <kevin.walls at oracle.com> wrote:
>>
>> Hi Kim,
>>
>> Yes we can try that way.  I can reword the intention to be less particular about keeping old windows behaviour.
>>
>> A new change is that in 8u I found g1GCPhaseTimes.cpp has a vsnprintf which was checking for -1 to mean buffer too small.
> Yikes! That's a pretty bad pre-existing bug!  This code doesn't seem
> to exist in later versions, having been replaced with UL.
>
>> http://cr.openjdk.java.net/~kevinw/8196882/webrev.02/
> Looks good to me.
>