RFR(M) : 8208655 : use JTreg skipped status in hotspot tests

Igor Ignatyev igor.ignatyev at oracle.com
Thu Aug 2 20:44:31 UTC 2018


Hi Harold,

you are right, thanks for catching this.

-- Igor

> On Aug 2, 2018, at 1:41 PM, Harold David Seigel <harold.seigel at oracle.com> wrote:
> 
> Hi Igor,
> 
> In TestBootNativeLibraryPath.java should this:
> 
>   + * @requiers vm.bits != 32
> 
> be
> 
>   @requires vm.bits == 32
> 
> Thanks, Harold
> 
> On 8/2/2018 4:32 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8208655/webrev.00/index.html
>>> 481 lines changed: 202 ins; 185 del; 94 mod;
>> Hi all,
>> 
>> could you please review this clean up of some hotspot tests? these tests are inapplicable in some of configurations, in some cases this can be expressed by @requiers, in others it can not be due to a dynamic nature. the latter cases are addressed by using new functionality added to jtreg 4.2 b13[1] -- throwing jtreg.SkippedException exception, which is known by jtreg and if jtreg catches this exception from a test, the test's will be marked as skipped.
>> 
>> webrev: http://cr.openjdk.java.net/~iignatyev//8208655/webrev.00/index.html
>> testing: hotspot tests
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8208655
>> 
>> Thanks,
>> -- Igor
>> 
>> [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7901596
> 



More information about the hotspot-dev mailing list