RFR(M) : 8208655 : use JTreg skipped status in hotspot tests
Igor Ignatyev
igor.ignatyev at oracle.com
Thu Aug 2 21:33:25 UTC 2018
Hi Ioi,
thanks for looking at it. please see my answers inline.
-- Igor
> On Aug 2, 2018, at 2:05 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
>
> Hi Igor,
>
> I looked at the 2 CDS tests:
>
> CdsSameObjectAlignment.java -> this line is not needed: import jtreg.SkippedException;
thx, I started the patch w/ adding jtreg.SkippedException in all these tests and later decided to use @requiers if possible. will remove the line before pushing.
>
>
> Also, the two tests didn't actually get run before??? Thanks for adding the @run lines :-)
they were run, if there is are @run tags (incl. build, compile, ignore), jtreg adds implicit '@run main'
>
> Thanks
>
> - ioi
>
>
>
> On 8/2/18 1:32 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8208655/webrev.00/index.html
>>> 481 lines changed: 202 ins; 185 del; 94 mod;
>> Hi all,
>>
>> could you please review this clean up of some hotspot tests? these tests are inapplicable in some of configurations, in some cases this can be expressed by @requiers, in others it can not be due to a dynamic nature. the latter cases are addressed by using new functionality added to jtreg 4.2 b13[1] -- throwing jtreg.SkippedException exception, which is known by jtreg and if jtreg catches this exception from a test, the test's will be marked as skipped.
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev//8208655/webrev.00/index.html
>> testing: hotspot tests
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8208655
>>
>> Thanks,
>> -- Igor
>>
>> [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7901596
>
More information about the hotspot-dev
mailing list