RFR (XL): 8208669: GC changes to allow enabling -Wreorder

Kim Barrett kim.barrett at oracle.com
Tue Aug 7 20:28:14 UTC 2018


> On Aug 6, 2018, at 8:35 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>> src/hotspot/share/gc/shared/workgroup.cpp
>> 190   MutexGangTaskDispatcher()
>> 
>> I don't really like how this one ended up being re-formated,
>> especially having the (empty) constructor body way far over to the
>> right.  Also, aligning the colon with the constructor name seems
>> pretty unusual.
> 
> You don't believe how many styles I observed in these set of patches…

I know!

> I tried to improve it.
> 
> http://cr.openjdk.java.net/~tschatzl/8208669/webrev.1 (full)
> http://cr.openjdk.java.net/~tschatzl/8208669/webrev.0_to_1 (diff)

Looks good.



More information about the hotspot-dev mailing list