RFR(XS): 8209915: Fix license headers
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri Aug 24 18:33:34 UTC 2018
I don't know why this JVMCI file in OpenJDK don't have license header. Lab's version has it:
https://github.com/graalvm/graal-jvmci-8/blob/master/jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodDataAccessor.java
Doug, do you know?
It also don't have empty line.
Regards,
Vladimir
On 8/24/18 11:15 AM, Mikael Vidstedt wrote:
>
>
>> On Aug 23, 2018, at 11:34 PM, Per Liden <per.liden at oracle.com> wrote:
>>
>> On 08/23/2018 11:34 PM, Mikael Vidstedt wrote:
>>> Please review this small change which fixes the license headers in three files:
>>> src/hotspot/share/memory/metaspace/virtualSpaceList.cpp
>>> src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodDataAccessor.java
>>> src/jdk.jfr/share/classes/jdk/jfr/internal/OldObjectSample.java
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8209915
>>> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8209915/webrev.00/open/webrev/
>>
>> Looks good.
>>
>> I guess it a space between line 22 and 23 in HotSpotMethodDataAccessor.java wouldn't hurt, but I don't need to see a new webrev for that.
>
> Vladimir/Per, thanks for the reviews!
>
> I actually did add en empty line after the license header in HotSpotMethodDataAccessor.java at first, but then I noticed that all the other files in that directory except one (src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java) lack that empty line, so for consistency reasons I decided to not add it after all.
>
> Cheers,
> Mikael
>
More information about the hotspot-dev
mailing list