RFR (XS) 8209911: More blob types in hs_err printout

[Volker Simonis]

Still OK!

As far as I can see we only printed the UncommonTraoBlob without the
COMPILER2 block.

Thanks,
Volker

Aleksey Shipilev <shade at redhat.com> schrieb am Fr. 24. Aug. 2018 um 19:18:

> Thanks!
>
> Actually, I looked at it again and wondered why the COMPILER2 block there.
> The UncommonTrapBlob
> itself is ifdef-ed by COMPILER2, but the is_uncommon_trap_blob() is pretty
> much available. So we can
> simplify this to:
>
> diff -r 76a51e26d0ac src/hotspot/share/runtime/frame.cpp
> --- a/src/hotspot/share/runtime/frame.cpp       Fri Aug 17 17:13:12 2018
> +0200
> +++ b/src/hotspot/share/runtime/frame.cpp       Fri Aug 24 19:15:45 2018
> +0200
> @@ -719,10 +719,18 @@
>        st->print("v  ~DeoptimizationBlob");
>      } else if (_cb->is_exception_stub()) {
>        st->print("v  ~ExceptionBlob");
>      } else if (_cb->is_safepoint_stub()) {
>        st->print("v  ~SafepointBlob");
> +    } else if (_cb->is_adapter_blob()) {
> +      st->print("v  ~AdapterBlob");
> +    } else if (_cb->is_vtable_blob()) {
> +      st->print("v  ~VtableBlob");
> +    } else if (_cb->is_method_handles_adapter_blob()) {
> +      st->print("v  ~MethodHandlesAdapterBlob");
> +    } else if (_cb->is_uncommon_trap_stub()) {
> +      st->print("v  ~UncommonTrapBlob");
>      } else {
>        st->print("v  blob " PTR_FORMAT, p2i(pc()));
>      }
>    } else {
>      print_C_frame(st, buf, buflen, pc());
>
> Thanks,
> -Aleksey
>
> On 08/24/2018 07:06 PM, Vladimir Kozlov wrote:
> > Looks good.
> >
> > thanks,
> > Vladimir
> >
> > On 8/23/18 11:42 AM, Aleksey Shipilev wrote:
> >> RFE:
> >>    https://bugs.openjdk.java.net/browse/JDK-8209911
> >>
> >> Patch:
> >>    http://cr.openjdk.java.net/~shade/8209911/8209911.patch
> >>
> >> Little debugging/post-mortem convenience. These are all blob types that
> have is_*_blob() tests.
> >> These blobs do not seem to have too much useful metadata to print from
> them, printing out the blob
> >> type is enough for now.
> >>
> >> Testing: Linux/x86_64 build only
> >>
> >> Thanks,
> >> -Aleksey
> >>
>
>
>