RFR (XS): 8209996: [PPC64] Fix JFR profiling

[Doerr, Martin]

Hi Gunter,

thanks for removing the incorrect checks.

"unextended_sp" could get checked against stack_end() or usable_stack_size.

"(fp - sp)" could get checked against ijava_state_size + parent_ijava_frame_abi_size.
In addition, "fp > sp" is redundant.

But I guess these checks are not important for PPC64, so I could live with what you've proposed.

Best regards,
Martin


-----Original Message-----
From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of Haug, Gunter
Sent: Dienstag, 28. August 2018 15:14
To: hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
Subject: RFR (XS): 8209996: [PPC64] Fix JFR profiling

Hi all,

There are two bugs in PPC64 platform code preventing a jtreg test (TestFullStackTrace.java) to complete successfully. Can I please have a review and a sponsor for the following change which fixes the issue:

https://bugs.openjdk.java.net/browse/JDK-8209996
http://cr.openjdk.java.net/~ghaug/webrevs/8209996/

frame::safe_for_sender made two assertions which are two strict. First, unextended_sp may well be greater than sp due to frame resizing (compacting) for interpreter fames. Second, top_ijava_frame_abi is only included in the top frame, obviously.

Thanks,
Gunter