[12] RFR(XS): 8210164: building Minimal VM fails with error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]

Aleksey Shipilev shade at redhat.com
Thu Aug 30 10:53:56 UTC 2018


On 08/30/2018 12:43 PM, Aleksei Voitylov wrote:
> please review this patch which fixes Minimal VM build error after b9f6a4427da9 was pushed. I'm
> suggesting to fix it explicitly as opposed to disabling the compiler warning.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8210164
> webrev: http://cr.openjdk.java.net/~avoitylov/webrev.8210164.02/

Looks good. Probably deserves a little comment why we are doing this, so we can later remove it if
we can prove that serial_phase_count is never 0, by code inspection.

Thanks,
-Aleksey



More information about the hotspot-dev mailing list