[12] RFR(XS): 8210164: building Minimal VM fails with error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]

[Aleksei Voitylov]

Hi,

added the assert. Thanks for the suggestion. Here is an updated webrev: 
http://cr.openjdk.java.net/~avoitylov/webrev.8210164.04/

-Aleksei


On 30/08/2018 18:30, Kim Barrett wrote:
>> On Aug 30, 2018, at 7:10 AM, Aleksei Voitylov <aleksei.voitylov at bell-sw.com> wrote:
>>
>> Aleksey,
>>
>> thanks for checking in. Here is an updated webrev: http://cr.openjdk.java.net/~avoitylov/webrev.8210164.03/
> Consider adding to the #else branch
>
>    STATIC_ASSERT(serial_phase_count == 0);
>
> Looks good to me.
>
>> -Aleksei
>>
>>
>> On 30/08/2018 13:53, Aleksey Shipilev wrote:
>>> On 08/30/2018 12:43 PM, Aleksei Voitylov wrote:
>>>> please review this patch which fixes Minimal VM build error after b9f6a4427da9 was pushed. I'm
>>>> suggesting to fix it explicitly as opposed to disabling the compiler warning.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8210164
>>>> webrev: http://cr.openjdk.java.net/~avoitylov/webrev.8210164.02/
>>> Looks good. Probably deserves a little comment why we are doing this, so we can later remove it if
>>> we can prove that serial_phase_count is never 0, by code inspection.
>>>
>>> Thanks,
>>> -Aleksey
>