8214976: Warn about uses of functions replaced for portability - was : RE: RFR: 8214944: replace strerror by os::strerror

[Baesken, Matthias]

Hi Kim, this looks great, thanks !

Maybe  strtok    could be considered too  for the list  of   __attribute__ declarations to cause warnings , 
 because  this got pushed recently :

8214773: Replace use of thread unsafe strtok

https://hg.openjdk.java.net/jdk/jdk/rev/8df9cf767f79


Best regards, Matthias



> -----Original Message-----
> From: Kim Barrett <kim.barrett at oracle.com>
> Sent: Freitag, 7. Dezember 2018 01:13
> To: Thomas Stüfe <thomas.stuefe at gmail.com>
> Cc: David Holmes <david.holmes at oracle.com>; HotSpot Open Source
> Developers <hotspot-dev at openjdk.java.net>; Baesken, Matthias
> <matthias.baesken at sap.com>
> Subject: Re: RFR: 8214944: replace strerror by os::strerror
> 
> > On Dec 6, 2018, at 4:07 PM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> >
> > On Thu, Dec 6, 2018 at 9:56 PM Kim Barrett <kim.barrett at oracle.com>
> wrote:
> >>
> >>> On Dec 6, 2018, at 7:56 AM, David Holmes <david.holmes at oracle.com>
> wrote:
> >>> Pity there is no way to detect when we use something like that which
> we shouldn’t.
> >>
> >> You asked for it:
> >> https://bugs.openjdk.java.net/browse/JDK-8214976
> >> :)
> >>
> >
> > That is neat!
> 
> Thanks.
> 
> > Note that I would like to have a simple, compiler-independent way to
> > locally disable those warnings though.
> 
> I’d left that as an exercise for the reader, but have since added a comment to
> the RFE
> describing how to do that.