RFR: 8215369: Jcstress pollute /var/tmp with temporary files.

Leonid Mesnik leonid.mesnik at oracle.com
Thu Dec 13 22:10:54 UTC 2018


Igor, Misha

Thank you for review. I'm pushing fix in jdk/jdk12 now.

Leonid 

> On Dec 13, 2018, at 1:46 PM, Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com> wrote:
> 
> +1
> 
> On 12/13/18, 1:43 PM, Igor Ignatyev wrote:
>> 
>>> On Dec 13, 2018, at 1:36 PM, Leonid Mesnik<leonid.mesnik at oracle.com>  wrote:
>>> 
>>> 
>>> 
>>>> On Dec 13, 2018, at 1:24 PM, Igor Ignatyev<igor.ignatyev at oracle.com<mailto:igor.ignatyev at oracle.com>>  wrote:
>>>> 
>>>> Hi Leonid,
>>>> 
>>>> shouldn't 2nd -Djava.io.tmpdir go after '--jvmArgs' ?
>>>>> 106         extraFlags.add("-Djava.io.tmpdir=" + System.getProperty("user.dir"));
>>>> the rest looks good.
>>> It is right after -jvmArgs.
>> ok, it was just me misreading udiff. looks good and trivial to me, ship it.
>>> 105         extraFlags.add("--jvmArgs");
>>> 106         extraFlags.add("-Djava.io.tmpdir=" + System.getProperty("user.dir"));
>>> then more --jvmArgs are added with other options in for loop.
>>> 
>>>> since this is test-only fix, I'd prefer to get it integrated into jdk/jdk12 rather than into jdk/jdk.
>>>> 
>>> ok.
>>> 
>>> Leonid
>>> 
>>>> Cheers,
>>>> -- Igor
>>>> 
>>>>> On Dec 13, 2018, at 12:57 PM, Leonid Mesnik<leonid.mesnik at oracle.com<mailto:leonid.mesnik at oracle.com>>  wrote:
>>>>> 
>>>>> Hi
>>>>> 
>>>>> Could you please review following fix which set property "java.io.tmpdir" for jctress harness and it's forked VMs . So any temporary files are created in test directory and not in system temp.
>>>>> 
>>>>> webrev: http://cr.openjdk.java.net/~lmesnik/8215369/webrev.00/<http://cr.openjdk.java.net/~lmesnik/8215369/webrev.00/>  <http://cr.openjdk.java.net/~lmesnik/8215369/webrev.00/<http://cr.openjdk.java.net/~lmesnik/8215369/webrev.00/>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8215369<https://bugs.openjdk.java.net/browse/JDK-8215369>  <https://bugs.openjdk.java.net/browse/JDK-8215369<https://bugs.openjdk.java.net/browse/JDK-8215369>>
>>>>> 
>>>>> Leonid



More information about the hotspot-dev mailing list