RFR (XS) [12] 8215374: 32-bit build failures after JDK-8181143 (Introduce diagnostic flag to abort VM on too long VM operations)

Aleksey Shipilev shade at redhat.com
Fri Dec 14 11:58:24 UTC 2018


On 12/14/18 12:28 PM, Roland Westrelin wrote:
> 
>> With all the excitement around fixing x86_32 issues before jdk12 fork today, I forgot to test my own
>> patch still builds on x86_32! It does not, because format specifiers are wrong. Fix:
>>
>> diff -r 408cdb799358 -r 1fb17b0a42c2 src/hotspot/share/runtime/vmThread.cpp
>> --- a/src/hotspot/share/runtime/vmThread.cpp    Thu Dec 13 22:32:38 2018 +0100
>> +++ b/src/hotspot/share/runtime/vmThread.cpp    Thu Dec 13 22:32:39 2018 +0100
>> @@ -206,7 +206,7 @@
>>    if (is_armed()) {
>>      jlong delay = (os::javaTimeMillis() - _arm_time);
>>      if (delay > AbortVMOnVMOperationTimeoutDelay) {
>> -      fatal("VM operation took too long: " SIZE_FORMAT " ms (timeout: " SIZE_FORMAT " ms)",
>> +      fatal("VM operation took too long: " JLONG_FORMAT " ms (timeout: " INTX_FORMAT " ms)",
>>              delay, AbortVMOnVMOperationTimeoutDelay);
>>      }
>>    }
> 
> That looks good and trivial to me.

Thank you! Pushed.

-Aleksey



More information about the hotspot-dev mailing list