RFR [XS]: 8215961: jdk/jfr/event/os/TestCPUInformation.java fails on AArch64

David Holmes david.holmes at oracle.com
Fri Dec 28 21:29:12 UTC 2018


Hi Matthias,

On 28/12/2018 11:35 pm, Baesken, Matthias wrote:
> Hello, please review this small  fix .
> 
> At the moment,  the test    jdk/jfr/event/os/TestCPUInformation.java   fails on AArch64 with the following error :
> 
> 
> java.lang.RuntimeException: Value not in (Intel, AMD, Unknown x86, SPARC, ARM, PPC, PowerPC, AArch64, zArch), field='description', value='0x50:0x0:0x000:1, simd'
> 
> 
> Reason is that  the  jdk.CPUInformation   event misses  a known CPU identifier value  in the  description,  see the  description part of it  :
> 
> Event: jdk.CPUInformation {
>     ....
>    description = "0x50:0x0:0x000:1, simd"
>    sockets = 8
>    ....
> }
> 
> 
> The patch adds  the CPU identifier info to  the   _cpu_desc   string  where it is taken from   .
> Please compare also with the ppc - implementation where the info  (PPC)   is already added .
> 
> vm_version_ext_ppc.cpp
> 
> 50     snprintf(_cpu_desc, CPU_DETAILED_DESC_BUF_SIZE, "PPC %s", features_string());
> 
> 
> 
> Bug/webrev :
> 
> https://bugs.openjdk.java.net/browse/JDK-8215961
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8215961.0/

Seems a reasonable approach.

I would expect other ARM systems to also be affected by this.

Thanks,
David

> 
> Thanks, Matthias
> 


More information about the hotspot-dev mailing list