[11] RFR(S): 8195695: NativeLibraryTest.java fails w/ 'Expected unloaded=1 but got=0'

[Vladimir Kozlov]

On 2/1/18 2:51 PM, David Holmes wrote:
> On 2/02/2018 6:01 AM, Vladimir Kozlov wrote:
>> Increase wait time will not always work.
>> May be better to add -Xmixed flag to test run command to overwrite passed -Xcomp flag.
>> I think it is fine for this tests to not run with -Xcomp - it has other purpose than testing JIT.
> 
> Wouldn't you just skip in -Xcomp as it would already be tested in mixed mode as part of another run?
> 
> @ requires vm.mode == "null" ??
> 
> David
> -----

Yes, skipping it for -Xcomp is also acceptable:

@requires vm.compMode != "Xcomp"

Vladimir

> 
>> Thanks,
>> Vladimir
>>
>> On 2/1/18 5:35 AM, Tobias Hartmann wrote:
>>> Hi,
>>>
>>> please review the following patch:
>>> https://bugs.openjdk.java.net/browse/JDK-8195695
>>> http://cr.openjdk.java.net/~thartmann/8195695/webrev.00/
>>>
>>> The test fails with -Xcomp because the native library is not unloaded. The problem is that -Xcomp 
>>> significantly slows
>>> down execution (especially on SPARC) and as a result 100 ms is not enough for unloading the 
>>> native library. I've
>>> increased the wait time to 1s and added 10 attempts.
>>>
>>> Verified on the machine that reproduced the problem.
>>>
>>> Thanks,
>>> Tobias
>>>