RFR : 8196578 : enhance errno_to_string function in os.cpp with some additional errno texts from AIX 7.1

[David Holmes]

+1 on moving to platform specific code.

Thanks,
David

On 2/02/2018 3:37 AM, Thomas Stüfe wrote:
> Hi Matthias,
> 
> This would probably better discussed in hotspot-runtime, no?
> 
> The old error codes and their descriptions were Posix (
> http://pubs.opengroup.org/onlinepubs/000095399/basedefs/errno.h.html). I do
> not really like spamming a shared file with AIX specific errno codes. Can
> we move platform specific error codes to platform files? Eg by having a
> platform specific version pd_errno_to_string(), which has a first shot at
> translating errno values, and only if that one returns no result reverting
> back to the shared version?
> 
> Small nit:
> 
> - DEFINE_ENTRY(ESTALE, "Reserved")
> + DEFINE_ENTRY(ESTALE, "No filesystem / stale NFS file handle")
> 
> I like the glibc text better, just "Stale file handle". NFS seems too
> specific, can handles for other remote file systems not get stale?
> 
> Kind Regards, Thomas
> 
> On Thu, Feb 1, 2018 at 5:16 PM, Baesken, Matthias <matthias.baesken at sap.com>
> wrote:
> 
>> Hello , I enhanced  the  errno - to -  error-text mappings   in os.cpp
>>   for a few errnos we find on AIX 7.1 .
>> Some of these added errnos are found as well on  Linux (e.g. SLES 11 / 12
>> ).
>>
>> Could you please check and review ?
>>
>> ( btw. there is good cross platform  info about the errnos at
>> http://www.ioplex.com/~miallen/errcmp.html     )
>>
>> Bug :
>>
>> https://bugs.openjdk.java.net/browse/JDK-8196578
>>
>> Webrev :
>>
>> http://cr.openjdk.java.net/~mbaesken/webrevs/8196578/
>>
>>
>>
>> Best regards, Matthias
>>