RFR 8196960 Exceptions in ConstantBootstrapsTest.java on SPARC

Lois Foltan lois.foltan at oracle.com
Wed Feb 7 20:23:15 UTC 2018


Looks good.
Lois

On 2/7/2018 3:21 PM, Paul Sandoz wrote:
> Hi,
>
> Please review this patch to exclude ConstantBootstrapsTest.java from executing on SPARC platforms. When condy is supported on SPARC this test can be updated to remove the restriction.
>
> Opportunistically i am also fixing an error in the @since on ConstantBootstraps.
>
> Thanks,
> Paul.
>
> diff -r 45b6aae769cc src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java
> --- a/src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java	Wed Feb 07 16:03:12 2018 +0100
> +++ b/src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java	Wed Feb 07 10:42:32 2018 -0800
> @@ -37,7 +37,7 @@
>    * unless the argument is specified to be unused or specified to accept a
>    * {@code null} value.
>    *
> - * @since 10
> + * @since 11
>    */
>   public final class ConstantBootstraps {
>       // implements the upcall from the JVM, MethodHandleNatives.linkDynamicConstant:
> diff -r 45b6aae769cc test/jdk/java/lang/invoke/condy/ConstantBootstrapsTest.java
> --- a/test/jdk/java/lang/invoke/condy/ConstantBootstrapsTest.java	Wed Feb 07 16:03:12 2018 +0100
> +++ b/test/jdk/java/lang/invoke/condy/ConstantBootstrapsTest.java	Wed Feb 07 10:42:32 2018 -0800
> @@ -25,6 +25,7 @@
>    * @test
>    * @bug 8186046 8195694
>    * @summary Test dynamic constant bootstraps
> + * @requires os.arch != "sparcv9"
>    * @library /lib/testlibrary/bytecode /java/lang/invoke/common
>    * @build jdk.experimental.bytecode.BasicClassBuilder test.java.lang.invoke.lib.InstructionHelper
>    * @run testng ConstantBootstrapsTest



More information about the hotspot-dev mailing list