RFR(XS) : 8197113 : combine multiple @key tags in jtreg tests

[Igor Ignatyev]

Hi Goetz, Harold.

Thank you for your review.

I totally agree that jtreg should be fixed to handle this one way or another, compatibility question can be solved by enabling this check based on  requiredVersion value. I have started discussion w/ Jon in CODETOOLS-7902076 <https://bugs.openjdk.java.net/browse/CODETOOLS-7902076>

Thanks,
-- Igor

> On Feb 8, 2018, at 7:21 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
> 
> Hi,
> 
> yes, the changes look good. 
> I have seen and fixed similar problems before. 
> Shouldn't jtreg be changed to accept and just concatenate multiple
> @key tags?  It will happen again, and, alternatively rejecting such tests by jtreg
> would break downward compatilbility.
> 
> Best regards,
>  Goetz.
> 
>> -----Original Message-----
>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
>> Behalf Of harold seigel
>> Sent: Donnerstag, 8. Februar 2018 15:26
>> To: hotspot-dev at openjdk.java.net
>> Subject: Re: RFR(XS) : 8197113 : combine multiple @key tags in jtreg tests
>> 
>> Hi Igor,
>> 
>> These changes look good.
>> 
>> Harold
>> 
>> On 2/7/2018 7:48 PM, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8197113/webrev.00/index.html
>>>> 47 lines changed: 11 ins; 29 del; 7 mod;
>>> Hi all,
>>> 
>>> could you please review this small fix for jtreg tests? jtreg doesn't support
>> multiple @key tags, this fix replaces multiple @key tags by one tag w/
>> combined value.
>>> 
>>> webrev:
>> http://cr.openjdk.java.net/~iignatyev//8197113/webrev.00/index.html
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8197113
>>> 
>>> Thanks,
>>> -- Igor
>