RFR: 8194691: Cleanup unnecessary casts in Atomic/OrderAccess uses

Kim Barrett kim.barrett at oracle.com
Thu Feb 8 19:01:53 UTC 2018


> On Feb 8, 2018, at 6:23 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> On Wed, 2018-02-07 at 17:00 -0500, Kim Barrett wrote:
>> Please review this removal of unnecessary casts in calls to Atomic
>> and
>> OrderAccess functions.  This isn't an attempt to be complete, but
>> eliminates some easily found and easy to fix cases.
>> 
>> Also changed some uses of Atomic::add with a negated value to instead
>> use Atomic::sub.
>> 
>> I've not made any changes around JavaThreadState and
>> Thread::_thread_state manipulation.  That may require more
>> refactoring
>> to deal with than I wanted to mix in with this otherwise fairly
>> straight-forward set of changes.
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8194691
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8194691/open.00/
>> 
>> Testing:
>> Mach5 {hs,jdk}-tier{1,2,3}
>> 
> 
> - the copyright line in dependencyContext.cpp should read (c) ...
> 2015, 2018, ..., mentioning both years like in other files.

Oops.  Thanks for spotting that.

> Looks good otherwise. I do not need to re-review above change added.
> 
> Thanks,
>  Thomas

Thanks.



More information about the hotspot-dev mailing list