RFR : 8197412 Enable docker container related tests for linux s390x
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Fri Feb 9 11:52:02 UTC 2018
Hi Matthias,
looks good!
Best regards,
Goetz.
> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> Behalf Of Baesken, Matthias
> Sent: Freitag, 9. Februar 2018 11:30
> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RFR : 8197412 Enable docker container related tests for linux s390x
>
> Hello, please review :
>
> 8197412 Enable docker container related tests for linux s390x
>
>
> This enables the docker related tests on Linux s390x. I tested on SLES12 ,
> docker version 17.09.1 .
> Some comments :
>
> TestCPUSets.java :
> is for now disabled on s390x because Cpus_allowed_list from
> /proc/self/status can give misleading values (larger than the currently
> available CPU number).
>
> DockerTestUtils.java :
> I changed the order to docker build to what is really documented .
> Docker help build says :
> Usage: docker build [OPTIONS] PATH | URL | -
> On older docker versions the order is important ( but on docker 17.x is seems
> to be ok to give the path first, still prefer to change it to what the help says ).
>
>
>
> Webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8197412.0/
>
>
> bug :
>
> https://bugs.openjdk.java.net/browse/JDK-8197412
>
>
>
> Thanks, Matthias
More information about the hotspot-dev
mailing list