RFR : 8197412 Enable docker container related tests for linux s390x

Dmitry Samersoff dmitry.samersoff at bell-sw.com
Mon Feb 12 12:25:34 UTC 2018


Matthias,

Looks good to me.

-Dmitry.

On 09.02.2018 13:29, Baesken, Matthias wrote:
> Hello, please review :
> 
> 8197412 Enable docker container related tests for linux s390x
> 
> 
> This enables the docker related tests on Linux s390x.   I tested on SLES12  , docker   version 17.09.1 .
> Some comments :
> 
> TestCPUSets.java :
> is for now disabled on s390x   because   Cpus_allowed_list   from   /proc/self/status  can give  misleading values (larger than the currently available CPU number).
> 
> DockerTestUtils.java :
>  I changed  the order to docker build  to what is really documented .
> Docker help build says :
> Usage:  docker build [OPTIONS] PATH | URL | -
> On older docker versions the order is important ( but on docker 17.x is seems to be ok to give the path first, still prefer to change it to what the help says ).
> 
> 
> 
> Webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8197412.0/
> 
> 
> bug :
> 
> https://bugs.openjdk.java.net/browse/JDK-8197412
> 
> 
> 
> Thanks, Matthias
> 


-- 
Dmitry Samersoff
http://devnull.samersoff.net
* There will come soft rains ...



More information about the hotspot-dev mailing list