RFR(S): JDK-8196590 Enable docker container related tests for linux AARCH64

[Bob Vandette]

Sorry for the late review, I was out last week.

I assume this was added to TestCPUSets.java due to the lack of cpuset support on the s390x OS.

@requires (os.arch != "s390x")

Is there any way to generalize the lack of cpusets rather than restricting this test on one arch?
I assume that this limitation is OS specific and not arch specific?

Bob.


> On Feb 12, 2018, at 9:37 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> 
>> 
>> I'll wait until you have your changes committed, then update my one.
>> 
> 
> Hi  Dmitry , my change  (8197412 Enable docker container related tests for linux s390x) is  now  in the jdk/hs repo .
> 
> Best regards, Matthias
> 
> 
>> -----Original Message-----
>> From: Dmitry Samersoff [mailto:dmitry.samersoff at bell-sw.com]
>> Sent: Montag, 12. Februar 2018 13:27
>> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
>> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>> Cc: mikhailo.seledtsov at oracle.com
>> Subject: Re: RFR(S): JDK-8196590 Enable docker container related tests for
>> linux AARCH64
>> 
>> Matthias,
>> 
>>> Hi  Dmitry, looks good to me (not a Reviewer however).
>> 
>> Thank you for the review.
>> 
>>> ( But guess it will be a merge conflict with 8197412 Enable docker
>> container related tests for linux s390x
>> 
>> I'll wait until you have your changes committed, then update my one.
>> 
>> -Dmitry
>> 
>> On 12.02.2018 11:15, Baesken, Matthias wrote:
>>> Hi  Dmitry, looks good to me (not a Reviewer however).
>>> 
>>> ( But guess it will be a merge conflict with 8197412 Enable docker container
>> related tests for linux s390x
>>> 
>>>> 
>>>> Webrev :
>>>> 
>>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8197412.0/
>>>> 
>>>> 
>>>> bug :
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8197412
>>>> 
>>> 
>>> )
>>> 
>>> 
>>> Best regards, Matthias
>>> 
>>> 
>>>> -----Original Message-----
>>>> From: Dmitry Samersoff [mailto:dmitry.samersoff at bell-sw.com]
>>>> Sent: Samstag, 10. Februar 2018 13:11
>>>> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>>>> Cc: Baesken, Matthias <matthias.baesken at sap.com>;
>>>> mikhailo.seledtsov at oracle.com
>>>> Subject: RFR(S): JDK-8196590 Enable docker container related tests for
>> linux
>>>> AARCH64
>>>> 
>>>> Everybody,
>>>> 
>>>> Please review small changes, that enables docker testing on
>> Linux/AArch64
>>>> 
>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8196590/webrev.01/
>>>> 
>>>> PS:
>>>> 
>>>> Matthias - I refactored VMProps.dockerSupport() a bit to make it more
>>>> readable, please check that it doesn't brake your work.
>>>> 
>>>> -Dmitry
>>>> 
>>>> --
>>>> Dmitry Samersoff
>>>> http://devnull.samersoff.net
>>>> * There will come soft rains ...
>> 
>> 
>> --
>> Dmitry Samersoff
>> http://devnull.samersoff.net
>> * There will come soft rains ...
>