RFR(S): JDK-8196590 Enable docker container related tests for linux AARCH64
Bob Vandette
bob.vandette at oracle.com
Mon Feb 12 16:30:05 UTC 2018
>
> On Feb 12, 2018, at 10:43 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
>
> Hi Bob, the issue on Linux s390x is that we get (at least on my test machine) from /proc/self/status Cpus_allowed_list a value that is much larger than the CPUs that are currently available.
> ( test <http://ld8443:8080/source/xref/openjdk-jdk-jdk/test/>/hotspot <http://ld8443:8080/source/xref/openjdk-jdk-jdk/test/hotspot/>/jtreg <http://ld8443:8080/source/xref/openjdk-jdk-jdk/test/hotspot/jtreg/>/runtime <http://ld8443:8080/source/xref/openjdk-jdk-jdk/test/hotspot/jtreg/runtime/>/containers <http://ld8443:8080/source/xref/openjdk-jdk-jdk/test/hotspot/jtreg/runtime/containers/>/docker <http://ld8443:8080/source/xref/openjdk-jdk-jdk/test/hotspot/jtreg/runtime/containers/docker/>/TestCPUAwareness.java <http://ld8443:8080/source/xref/openjdk-jdk-jdk/test/hotspot/jtreg/runtime/containers/docker/TestCPUAwareness.java> is looking at the Cpus_allowed_list value )
>
> From what I heard, the value from /proc/self/status Cpus_allowed_list on the Linux s390x test machine is more like an upper bound of potentially hot-pluggable CPUs .
> So far I am not sure about the details, I try to find out a better way to get the values .
>
> So it is not really a lack of cpusets , but more like a difference compared to other systems .
>
That’s odd since the entry is documented as CPUs that you can be scheduled on!
What does your Cpus_allowed entry contain? It looks like that entry was available
before the list form.
Also the /proc/<pid>/status file for each process has four added
lines, displaying the process's Cpus_allowed (on which CPUs it may be
scheduled) and Mems_allowed (on which memory nodes it may obtain
memory), in the two formats Mask Format and List Format (see below)
as shown in the following example:
Cpus_allowed: ffffffff,ffffffff,ffffffff,ffffffff
Cpus_allowed_list: 0-127
Mems_allowed: ffffffff,ffffffff
Mems_allowed_list: 0-63
The "allowed" fields were added in Linux 2.6.24; the "allowed_list"
fields were added in Linux 2.6.26.
Bob.
>
> Best regards, Matthias
>
>
> From: Bob Vandette [mailto:bob.vandette at oracle.com <mailto:bob.vandette at oracle.com>]
> Sent: Montag, 12. Februar 2018 15:59
> To: Baesken, Matthias <matthias.baesken at sap.com <mailto:matthias.baesken at sap.com>>
> Cc: Dmitry Samersoff <dmitry.samersoff at bell-sw.com <mailto:dmitry.samersoff at bell-sw.com>>; hotspot-dev at openjdk.java.net <mailto:hotspot-dev at openjdk.java.net>
> Subject: Re: RFR(S): JDK-8196590 Enable docker container related tests for linux AARCH64
>
> Sorry for the late review, I was out last week.
>
> I assume this was added to TestCPUSets.java due to the lack of cpuset support on the s390x OS.
>
> @requires (os.arch != "s390x")
>
> Is there any way to generalize the lack of cpusets rather than restricting this test on one arch?
> I assume that this limitation is OS specific and not arch specific?
>
> Bob.
>
>
> On Feb 12, 2018, at 9:37 AM, Baesken, Matthias <matthias.baesken at sap.com <mailto:matthias.baesken at sap.com>> wrote:
>
>
> I'll wait until you have your changes committed, then update my one.
>
>
> Hi Dmitry , my change (8197412 Enable docker container related tests for linux s390x) is now in the jdk/hs repo .
>
> Best regards, Matthias
>
>
>
> -----Original Message-----
> From: Dmitry Samersoff [mailto:dmitry.samersoff at bell-sw.com <mailto:dmitry.samersoff at bell-sw.com>]
> Sent: Montag, 12. Februar 2018 13:27
> To: Baesken, Matthias <matthias.baesken at sap.com <mailto:matthias.baesken at sap.com>>; 'hotspot-
> dev at openjdk.java.net <mailto:dev at openjdk.java.net>' <hotspot-dev at openjdk.java.net <mailto:hotspot-dev at openjdk.java.net>>
> Cc: mikhailo.seledtsov at oracle.com <mailto:mikhailo.seledtsov at oracle.com>
> Subject: Re: RFR(S): JDK-8196590 Enable docker container related tests for
> linux AARCH64
>
> Matthias,
>
>
> Hi Dmitry, looks good to me (not a Reviewer however).
>
> Thank you for the review.
>
>
> ( But guess it will be a merge conflict with 8197412 Enable docker
> container related tests for linux s390x
>
> I'll wait until you have your changes committed, then update my one.
>
> -Dmitry
>
> On 12.02.2018 11:15, Baesken, Matthias wrote:
>
> Hi Dmitry, looks good to me (not a Reviewer however).
>
> ( But guess it will be a merge conflict with 8197412 Enable docker container
> related tests for linux s390x
>
>
>
>
> Webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8197412.0/ <http://cr.openjdk.java.net/~mbaesken/webrevs/8197412.0/>
>
>
> bug :
>
> https://bugs.openjdk.java.net/browse/JDK-8197412 <https://bugs.openjdk.java.net/browse/JDK-8197412>
>
> )
>
>
> Best regards, Matthias
>
>
>
> -----Original Message-----
> From: Dmitry Samersoff [mailto:dmitry.samersoff at bell-sw.com <mailto:dmitry.samersoff at bell-sw.com>]
> Sent: Samstag, 10. Februar 2018 13:11
> To: 'hotspot-dev at openjdk.java.net <mailto:hotspot-dev at openjdk.java.net>' <hotspot-dev at openjdk.java.net <mailto:hotspot-dev at openjdk.java.net>>
> Cc: Baesken, Matthias <matthias.baesken at sap.com <mailto:matthias.baesken at sap.com>>;
> mikhailo.seledtsov at oracle.com <mailto:mikhailo.seledtsov at oracle.com>
> Subject: RFR(S): JDK-8196590 Enable docker container related tests for
> linux
>
> AARCH64
>
> Everybody,
>
> Please review small changes, that enables docker testing on
> Linux/AArch64
>
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8196590/webrev.01/ <http://cr.openjdk.java.net/~dsamersoff/JDK-8196590/webrev.01/>
>
> PS:
>
> Matthias - I refactored VMProps.dockerSupport() a bit to make it more
> readable, please check that it doesn't brake your work.
>
> -Dmitry
>
> --
> Dmitry Samersoff
> http://devnull.samersoff.net <http://devnull.samersoff.net/>
> * There will come soft rains ...
>
>
> --
> Dmitry Samersoff
> http://devnull.samersoff.net <http://devnull.samersoff.net/>
> * There will come soft rains ...
More information about the hotspot-dev
mailing list