(11) RFR (XS) JDK-8196889: VS2017 Unable to Instantiate OrderAccess::release_store with an Incomplete Class Within an Inlined Method

[Lois Foltan]

Thank you Kim for the review and for consulting with me on this issue!
Lois

On 2/13/2018 2:48 PM, Kim Barrett wrote:
>> On Feb 13, 2018, at 1:47 PM, Lois Foltan <lois.foltan at oracle.com> wrote:
>>
>> Please review this small fix for a VS2017 compilation error.  The inaccessibility of the private Atomic::IsPointerConvertible in the template arguments for the partial specialization of Atomic::StoreImpl causes a (C2027) compilation error indicating a use of an undefined type has occurred.  This issue manifests itself only in certain coding scenarios, for example, when OrderAccess::release_store() is called from within an inlined method of a class where one of the types used to instantiate is the currently being defined class.
>>
>> open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8196889/webrev/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8196889
>>
>> Building & Testing complete (hs-tier1-3, jdk-tier1-3)
>>
>> Thanks,
>> Lois
> Looks good.
>
> I wish we had a better understanding of the problem, but at this point I’m ready to concede that
> something is going awry that probably requires debugging the compiler to figure out.  I will try to
> make a small reproducer to turn over to Microsoft.
>