(11) RFR (XS) JDK-8196889: VS2017 Unable to Instantiate OrderAccess::release_store with an Incomplete Class Within an Inlined Method

[Lois Foltan]

On 2/13/2018 2:58 PM, Thomas Stüfe wrote:

>
>
> On Tue, Feb 13, 2018 at 8:55 PM, Thomas Stüfe <thomas.stuefe at gmail.com 
> <mailto:thomas.stuefe at gmail.com>> wrote:
>
>     HI Lois,
>
>     this looks fine.
>
>     I have to ask though, what version of VS2017 are you using? When I
>     try to build (VS 2017 community edition), I get only as far as the
>     adlc before the first couple of:
>
>     error C2956: sized deallocation function 'operator delete(void*,
>     size_t)' would be chosen as placement deallocation function.
>
>     (in arena.cpp in adlc, class Chunk).
>
>     Thanks, Thomas
>
>
>
> Oh, I just found https://bugs.openjdk.java.net/browse/JDK-8196880. So 
> you guys are already on it. Great. Do you have a patch already for 
> trying out?

Thank you Thomas for the review!  No patch yet, but working on it.
Lois

>
>
>
>     On Tue, Feb 13, 2018 at 7:47 PM, Lois Foltan
>     <lois.foltan at oracle.com <mailto:lois.foltan at oracle.com>> wrote:
>
>         Please review this small fix for a VS2017 compilation error.
>         The inaccessibility of the private
>         Atomic::IsPointerConvertible in the template arguments for the
>         partial specialization of Atomic::StoreImpl causes a (C2027)
>         compilation error indicating a use of an undefined type has
>         occurred.  This issue manifests itself only in certain coding
>         scenarios, for example, when OrderAccess::release_store() is
>         called from within an inlined method of a class where one of
>         the types used to instantiate is the currently being defined
>         class.
>
>         open webrev at
>         http://cr.openjdk.java.net/~lfoltan/bug_jdk8196889/webrev/
>         <http://cr.openjdk.java.net/%7Elfoltan/bug_jdk8196889/webrev/>
>         bug link https://bugs.openjdk.java.net/browse/JDK-8196889
>         <https://bugs.openjdk.java.net/browse/JDK-8196889>
>
>         Building & Testing complete (hs-tier1-3, jdk-tier1-3)
>
>         Thanks,
>         Lois
>
>
>
>