(11) RFR (S) JDK-8196997: VS2017 The non-Standard std::tr1 namespace and TR1-only machinery are deprecated and will be removed

Kim Barrett kim.barrett at oracle.com
Thu Feb 15 06:46:05 UTC 2018


> On Feb 14, 2018, at 9:06 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Lois,
> 
> On 15/02/2018 4:07 AM, Lois Foltan wrote:
>> Please review this small fix to ignore the VS2017 deprecation warning for non-Standard std::tr1 namespace and TR1-only machinery when compiling gtest.  A corresponding RFE has been added to upgrade gtest.
>> open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8196997/webrev/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8196997
> 
> What is the change in  make/common/MakeBase.gmk ?

It increases the maximum number of arguments that can be passed to things like SetupNativeCompilation.
Without it, the other change produces a build error, telling you there were too many parameters, and
to update MAX_PARAMS.

> Thanks,
> David
> 
>> gtest upgrade RFE link https://bugs.openjdk.java.net/browse/JDK-8197951
>> Thanks,
>> Lois




More information about the hotspot-dev mailing list