(11) RFR (S) JDK-8196997: VS2017 The non-Standard std::tr1 namespace and TR1-only machinery are deprecated and will be removed

[Lois Foltan]

On 2/15/2018 1:46 AM, Kim Barrett wrote:
>> On Feb 14, 2018, at 9:06 PM, David Holmes <david.holmes at oracle.com> wrote:
>>
>> Hi Lois,
>>
>> On 15/02/2018 4:07 AM, Lois Foltan wrote:
>>> Please review this small fix to ignore the VS2017 deprecation warning for non-Standard std::tr1 namespace and TR1-only machinery when compiling gtest.  A corresponding RFE has been added to upgrade gtest.
>>> open webrev at http://cr.openjdk.java.net/~lfoltan/bug_jdk8196997/webrev/
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8196997
>> What is the change in  make/common/MakeBase.gmk ?
> It increases the maximum number of arguments that can be passed to things like SetupNativeCompilation.
> Without it, the other change produces a build error, telling you there were too many parameters, and
> to update MAX_PARAMS.
For example, the build error generated when MAX_PARAMS is not increased is:
lib/CompileGtest.gmk:65: *** Internal makefile error: Too many named 
arguments to macro, please update MAX_PARAMS in MakeBase.gmk.  Stop.
make/Main.gmk:268: recipe for target 'hotspot-server-libs' 
failedmake[2]: *** [hotspot-server-libs] Error 2
Thanks,
Lois

>
>> Thanks,
>> David
>>
>>> gtest upgrade RFE link https://bugs.openjdk.java.net/browse/JDK-8197951
>>> Thanks,
>>> Lois
>