RFR : 8198275 AIX build broken after latest whitebox.cpp changes

[Doerr, Martin]

Thank you, David. That makes sense.

Best regards,
Martin


-----Original Message-----
From: David Holmes [mailto:david.holmes at oracle.com] 
Sent: Freitag, 16. Februar 2018 13:33
To: Doerr, Martin <martin.doerr at sap.com>; Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
Cc: Simonis, Volker <volker.simonis at sap.com>
Subject: Re: RFR : 8198275 AIX build broken after latest whitebox.cpp changes

I have to wonder why all this Elf file stuff is in shared code in the 
first place. :(

The earlier Elf file stuff in whitebox.cpp is in a #ifdef LINUX guard - 
in fact "utilities/elfFile.hpp" is now included twice in that file! So 
this is getting very messy. I'll file a RFE to have it cleaned up.

David

On 16/02/2018 8:50 PM, Doerr, Martin wrote:
> Hi Matthias,
> 
> thanks for fixing. Reviewed and pushed as it is a very trivial build fix for AIX.
> 
> Best regards,
> Martin
> 
> 
> From: Baesken, Matthias
> Sent: Freitag, 16. Februar 2018 11:40
> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Cc: Doerr, Martin <martin.doerr at sap.com>; Simonis, Volker <volker.simonis at sap.com>
> Subject: RFR : 8198275 AIX build broken after latest whitebox.cpp changes
> 
> Hi, please review  this AIX related fix.
> 
> Recent changes  in jdk/hs  caused a compilation error :
> 
> The AIX build is broken, error is /nb/rs6000_64/nightly/jdk-hs/src/hotspot/share/utilities/elfFile.hpp", line 33.10: 1540-0836 (S) The #include file <elf.h> is not found. (whitebox.o compilation failed).
> 
> The fix  handles AIX in the same way Windows and "APPLE"  is handled .
> 
> Bug :
> 
> https://bugs.openjdk.java.net/browse/JDK-8198275
> 
> Webrev :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8198275.0/
> 
> 
> 
> Thanks, Matthias
>